Uploaded image for project: 'ONOS'
  1. ONOS
  2. ONOS-1171

NPE in GossipDeviceStore when disconnecting switches

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      commit 5000a754d873c42935ce098f2c7b3b35e3408bf2

      Description

      On a 7 node cluster:
      Start cluster
      start mininet
      connect switches
      assign mastership of switches
      shutdown mininet

      from ONOS 7 logs:

      015-02-24 10:30:56,764 | INFO  | ew I/O worker #1 | OFChannelHandler                 | 132 - org.onosproject.onos-of-ctl - 1.1.0.SNAPSHOT | Switch disconnected callback for sw:OFSwitchImplOVS13 [/10.128.30.9:48142 DPID[00:00:00:00:00:00:10:00]]. Cleaning up ...
2015-02-24 10:30:56,764 | INFO  | ew I/O worker #1 | OFChannelHandler                 | 132 - org.onosproject.onos-of-ctl - 1.1.0.SNAPSHOT | OFSwitchImplOVS13 [/10.128.30.9:48142 DPID[00:00:00:00:00:00:10:00]]:removal called
2015-02-24 10:30:56,764 | WARN  | ew I/O worker #1 | ntrollerImpl$OpenFlowSwitchAgent | 132 - org.onosproject.onos-of-ctl - 1.1.0.SNAPSHOT | sw was null for 00:00:00:00:00:00:10:00
2015-02-24 10:30:56,764 | WARN  | ew I/O worker #1 | ntrollerImpl$OpenFlowSwitchAgent | 132 - org.onosproject.onos-of-ctl - 1.1.0.SNAPSHOT | removal for 00:00:00:00:00:00:10:00
2015-02-24 10:30:56,764 | INFO  | ew I/O worker #1 | FlowStatsCollector               | 137 - org.onosproject.onos-of-provider-flow - 1.1.0.SNAPSHOT | Stopping Stats collection thread for 00:00:00:00:00:00:10:00
2015-02-24 10:30:56,764 | WARN  | ew I/O worker #1 | ntrollerImpl$OpenFlowSwitchAgent | 132 - org.onosproject.onos-of-ctl - 1.1.0.SNAPSHOT | removal for 00:00:00:00:00:00:10:00
2015-02-24 10:30:56,765 | INFO  | ew I/O worker #1 | DeviceManager                    | 158 - org.onosproject.onos-core-net - 1.1.0.SNAPSHOT | Device of:0000000000001000 disconnected from this node
2015-02-24 10:30:56,777 | WARN  | ew I/O worker #1 | DeviceManager                    | 158 - org.onosproject.onos-core-net - 1.1.0.SNAPSHOT | Failed to mark of:0000000000001000 offline
2015-02-24 10:30:56,778 | WARN  | onos-device-fg-5 | GossipDeviceStore                | 160 - org.onosproject.onos-core-dist - 1.1.0.SNAPSHOT | Exception thrown handling port injected event.
java.lang.NullPointerException: Instance ID cannot be null
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:226)[43:com.google.guava:18.0.0]
        at org.onosproject.cluster.impl.ClusterManager.getNode(ClusterManager.java:90)[158:org.onosproject.onos-core-net:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager.unicast(ClusterCommunicationManager.java:146)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager.unicast(ClusterCommunicationManager.java:142)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.device.impl.GossipDeviceStore.updatePorts(GossipDeviceStore.java:544)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.device.impl.GossipDeviceStore$PortInjectedEventListener.handle(GossipDeviceStore.java:1496)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager$InternalClusterMessageHandler.handle(ClusterCommunicationManager.java:217)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onlab.netty.NettyMessagingService$3.lambda$handle$0(NettyMessagingService.java:223)[162:org.onosproject.onlab-netty:1.1.0.SNAPSHOT]
        at org.onlab.netty.NettyMessagingService$3$$Lambda$80/1850582515.run(Unknown Source)[162:org.onosproject.onlab-netty:1.1.0.SNAPSHOT]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_25]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_25]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_25]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_25]
        at java.lang.Thread.run(Thread.java:745)[:1.8.0_25]
2015-02-24 10:30:56,779 | WARN  | onos-device-fg-4 | GossipDeviceStore                | 160 - org.onosproject.onos-core-dist - 1.1.0.SNAPSHOT | Exception thrown handling port injected event.
java.lang.NullPointerException: Instance ID cannot be null
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:226)[43:com.google.guava:18.0.0]
        at org.onosproject.cluster.impl.ClusterManager.getNode(ClusterManager.java:90)[158:org.onosproject.onos-core-net:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager.unicast(ClusterCommunicationManager.java:146)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager.unicast(ClusterCommunicationManager.java:142)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.device.impl.GossipDeviceStore.updatePorts(GossipDeviceStore.java:544)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.device.impl.GossipDeviceStore$PortInjectedEventListener.handle(GossipDeviceStore.java:1496)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager$InternalClusterMessageHandler.handle(ClusterCommunicationManager.java:217)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onlab.netty.NettyMessagingService$3.lambda$handle$0(NettyMessagingService.java:223)[162:org.onosproject.onlab-netty:1.1.0.SNAPSHOT]
        at org.onlab.netty.NettyMessagingService$3$$Lambda$80/1850582515.run(Unknown Source)[162:org.onosproject.onlab-netty:1.1.0.SNAPSHOT]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_25]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_25]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_25]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_25]
        at java.lang.Thread.run(Thread.java:745)[:1.8.0_25]
2015-02-24 10:30:56,778 | WARN  | onos-device-fg-3 | GossipDeviceStore                | 160 - org.onosproject.onos-core-dist - 1.1.0.SNAPSHOT | Exception thrown handling port injected event.
java.lang.NullPointerException: Instance ID cannot be null
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:226)[43:com.google.guava:18.0.0]
        at org.onosproject.cluster.impl.ClusterManager.getNode(ClusterManager.java:90)[158:org.onosproject.onos-core-net:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager.unicast(ClusterCommunicationManager.java:146)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager.unicast(ClusterCommunicationManager.java:142)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.device.impl.GossipDeviceStore.updatePorts(GossipDeviceStore.java:544)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.device.impl.GossipDeviceStore$PortInjectedEventListener.handle(GossipDeviceStore.java:1496)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager$InternalClusterMessageHandler.handle(ClusterCommunicationManager.java:217)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onlab.netty.NettyMessagingService$3.lambda$handle$0(NettyMessagingService.java:223)[162:org.onosproject.onlab-netty:1.1.0.SNAPSHOT]
        at org.onlab.netty.NettyMessagingService$3$$Lambda$80/1850582515.run(Unknown Source)[162:org.onosproject.onlab-netty:1.1.0.SNAPSHOT]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_25]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_25]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_25]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_25]
        at java.lang.Thread.run(Thread.java:745)[:1.8.0_25]
2015-02-24 10:30:56,799 | WARN  | onos-device-fg-7 | GossipDeviceStore                | 160 - org.onosproject.onos-core-dist - 1.1.0.SNAPSHOT | Exception thrown handling port injected event.
java.lang.NullPointerException: Instance ID cannot be null
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:226)[43:com.google.guava:18.0.0]
        at org.onosproject.cluster.impl.ClusterManager.getNode(ClusterManager.java:90)[158:org.onosproject.onos-core-net:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager.unicast(ClusterCommunicationManager.java:146)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager.unicast(ClusterCommunicationManager.java:142)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.device.impl.GossipDeviceStore.updatePorts(GossipDeviceStore.java:544)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.device.impl.GossipDeviceStore$PortInjectedEventListener.handle(GossipDeviceStore.java:1496)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager$InternalClusterMessageHandler.handle(ClusterCommunicationManager.java:217)[160:org.onosproject.onos-core-dist:1.1.0.SNAPSHOT]
        at org.onlab.netty.NettyMessagingService$3.lambda$handle$0(NettyMessagingService.java:223)[162:org.onosproject.onlab-netty:1.1.0.SNAPSHOT]
        at org.onlab.netty.NettyMessagingService$3$$Lambda$80/1850582515.run(Unknown Source)[162:org.onosproject.onlab-netty:1.1.0.SNAPSHOT]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_25]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_25]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_25]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_25]
        at java.lang.Thread.run(Thread.java:745)[:1.8.0_25]

        Attachments

        # Subject Branch Project Status CR V
        2795,3 Fix for NPE master onos Status: MERGED +2 +1

          Activity

            People

            Assignee:
            jhall Jon Hall
            Reporter:
            jhall Jon Hall
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: