Uploaded image for project: 'ONOS'
  1. ONOS
  2. ONOS-1247

LinkCollectionIntent instances created without using Intent.constraints()

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 1.2.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      ONOS master as of March 9, 2015 (pre onos-1.1 release)

      Description

      In several places in the code we create LinkCollectionIntent entries
      by ignoring the corresponding Intent.constraints(). E.g., inside
      SinglePointToMultiPointIntentCompiler.compile(SinglePointToMultiPointIntent, ...) we have the following code:

      Intent result = new LinkCollectionIntent(intent.appId(),
      intent.selector(),
      intent.treatment(), links,
      ImmutableSet.of(intent.ingressPoint()),
      intent.egressPoints(), Collections.emptyList());

      The last argument is Collections.emptyList() when it should be
      intent.constraints()

      Similar change should be applied in all places we create such LinkCollectionIntent.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            shimizu Shimizu Sho
            Reporter:
            pavlin Pavlin Radoslavov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: