Uploaded image for project: 'ONOS'
  1. ONOS
  2. ONOS-1910

NPE in DeviceManager when disconnecting from switch

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      commit da580889e275567ca3f53c09c8d1c8eff194f73c

      Description

      If there is an IllegalState Exception when trying to mark a node offline sometimes term is null resulting in a null pointer exception.

      2015-05-13 10:06:11,178 | WARN  | w I/O worker #12 | DeviceManager                    | 77 - org.onosproject.onos-core-net - 1.2.0.SNAPSHOT | Failed to mark of:0000000000002800 offline
      2015-05-13 10:06:11,198 | ERROR | ew I/O worker #4 | OFChannelHandler                 | 165 - org.onosproject.onos-of-ctl - 1.2.0.SNAPSHOT | Error while processing message from switch org.onosproject.driver.handshaker.DefaultSwitchHandShaker [/10.128.30.9:58468 DPID[00:00:00:00:00:00:30:04]]state ACTIVE
      java.lang.NullPointerException
              at org.onosproject.net.device.impl.DeviceManager$InternalDeviceProviderService.deviceDisconnected(DeviceManager.java:368)
              at org.onosproject.provider.of.device.impl.OpenFlowDeviceProvider$InternalDeviceProvider.switchRemoved(OpenFlowDeviceProvider.java:278)
              at org.onosproject.openflow.controller.impl.OpenFlowControllerImpl$OpenFlowSwitchAgent.removeConnectedSwitch(OpenFlowControllerImpl.java:515)
              at org.onosproject.openflow.controller.driver.AbstractOpenFlowSwitch.removeConnectedSwitch(AbstractOpenFlowSwitch.java:255)
              at org.onosproject.openflow.controller.impl.OFChannelHandler.channelDisconnected(OFChannelHandler.java:1067)
              at org.jboss.netty.handler.timeout.IdleStateAwareChannelHandler.handleUpstream(IdleStateAwareChannelHandler.java:36)[45:org.jboss.netty:3.9.2.Final]
              at org.jboss.netty.handler.codec.frame.FrameDecoder.cleanup(FrameDecoder.java:493)[45:org.jboss.netty:3.9.2.Final]
              at org.jboss.netty.handler.codec.frame.FrameDecoder.channelDisconnected(FrameDecoder.java:365)[45:org.jboss.netty:3.9.2.Final]
              at org.jboss.netty.channel.Channels.fireChannelDisconnected(Channels.java:396)[45:org.jboss.netty:3.9.2.Final]
              at org.jboss.netty.channel.socket.nio.AbstractNioWorker.close(AbstractNioWorker.java:360)[45:org.jboss.netty:3.9.2.Final]
              at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:93)[45:org.jboss.netty:3.9.2.Final]
              at org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:108)[45:org.jboss.netty:3.9.2.Final]
              at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:318)
              at org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)[45:org.jboss.netty:3.9.2.Final]
              at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)[45:org.jboss.netty:3.9.2.Final]
              at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_25]
              at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_25]
              at java.lang.Thread.run(Thread.java:745)[:1.8.0_25]
      

      Since this only seems to happen when disconnecting a switch and the role is still set as unavailable, I think this is a lower priority

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            jhall Jon Hall
            Reporter:
            jhall Jon Hall
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: