SDN-IP installs too many point-to-point intents for some configurations

With some configurations involving multiple peering sessions to one peer, SDN-IP will install too many PointToPointIntents for BGP connectivity. Furthermore, the extra intents often have IP addresses that do not make sense (src and dst IPs are in different subnets, which is not supported by SDN-IP).

This is because the logic in PeerConnectivityManager which is deciding which peers to add intents between only matches BgpPeers and BgpSpeakers based on a common connect point. This match is too broad because there can be multiple peering sessions configured on a single connect point. This match should be made more specific and should check the IP addresses of the peer/speaker to make sure they are in the same subnet before deciding to set up point-to-point connectivity.