Uploaded image for project: 'ONOS'
  1. ONOS
  2. ONOS-3346

NPE when disallowing a connected device via netcfg

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.4.0
    • Component/s: None
    • Labels:
      None
    • Environment:
    • Sprint:
      Emu Sprint 3 (11/2 - 11/20)

      Description

      Setup: 7 node cluster with a switch only connected to ONOS1

      Push the following network config to ONOS1 through rest:

      {
        "domains" : { },
        "devices" : {
          "of:0000000000000001" : {
            "basic" : {
              "allowed" : false
            }
          }
        },
        "ports" : { },
        "hosts" : { },
        "links" : { }
      }
      

      The following exceptions are thrown:

      2015-11-11 13:05:28,116 | INFO  | event-dispatch-0 | DeviceManager                    | 143 - org.onosproject.onos-core-net - 1.4.0.SNAPSHOT | Detected Device network config event CONFIG_UPDATED
      2015-11-11 13:05:28,211 | WARN  | onos-device-fg-1 | GossipDeviceStore                | 145 - org.onosproject.onos-core-dist - 1.4.0.SNAPSHOT | Exception thrown handling device remove
      java.lang.NullPointerException
              at org.onosproject.store.device.impl.GossipDeviceStore.removeDeviceInternal(GossipDeviceStore.java:989)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onosproject.store.device.impl.GossipDeviceStore.removeDevice(GossipDeviceStore.java:968)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onosproject.store.device.impl.GossipDeviceStore$InternalRemoveRequestListener.handle(GossipDeviceStore.java:1517)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager$InternalClusterMessageHandler.apply(ClusterCommunicationManager.java:223)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager$InternalClusterMessageHandler.apply(ClusterCommunicationManager.java:213)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onlab.netty.NettyMessaging.lambda$null$4(NettyMessaging.java:214)
              at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_60]
              at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_60]
              at java.lang.Thread.run(Thread.java:745)[:1.8.0_60]
      2015-11-11 13:05:28,216 | WARN  | onos-device-fg-2 | GossipDeviceStore                | 145 - org.onosproject.onos-core-dist - 1.4.0.SNAPSHOT | Exception thrown handling device remove
      java.lang.NullPointerException
              at org.onosproject.store.device.impl.GossipDeviceStore.removeDeviceInternal(GossipDeviceStore.java:989)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onosproject.store.device.impl.GossipDeviceStore.removeDevice(GossipDeviceStore.java:968)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onosproject.store.device.impl.GossipDeviceStore$InternalRemoveRequestListener.handle(GossipDeviceStore.java:1517)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager$InternalClusterMessageHandler.apply(ClusterCommunicationManager.java:223)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onosproject.store.cluster.messaging.impl.ClusterCommunicationManager$InternalClusterMessageHandler.apply(ClusterCommunicationManager.java:213)[145:org.onosproject.onos-core-dist:1.4.0.SNAPSHOT]
              at org.onlab.netty.NettyMessaging.lambda$null$4(NettyMessaging.java:214)
              at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_60]
              at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_60]
              at java.lang.Thread.run(Thread.java:745)[:1.8.0_60]
      2015-11-11 13:05:28,223 | INFO  | event-dispatch-0 | DeviceManager                    | 143 - org.onosproject.onos-core-net - 1.4.0.SNAPSHOT | Detected Device network config event CONFIG_UPDATED
      

      In addition (maybe unrelated) when all configurations are removed, or allowed is set to True, the device does not appear in the topology again unless it disconnects then reconnects from the ONOS node

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              • Assignee:
                jhall Jon Hall
                Reporter:
                jhall Jon Hall
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: