Uploaded image for project: 'ONOS'
  1. ONOS
  2. ONOS-6480

Bug fix in NewAdaptiveFlowStatsCollector.java

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.10.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      1
    • Sprint:
      K Bug Sprint

      Description

      In NewAdaptiveFlowStatsCollector.java in the runnables for CalAndShortFlowsTask, MidFlows and LongFlowsTask, callCount*FlowsTask are compared with ENTIRE_POLL_TIMES.
      ENTIRE_POLL_TIMES in comments is mentioned to be variable greater or equal than common multople of MID_POLL_TIMES and LONG_POLL_TIMES, so it is not necessarily a multiple of MID_POLL_TIMES and LONG_POLL_TIMES.
      The comparison in the runnables should be "greater than or equal to" rather than "equal to".
      The current implementation should work well, but if the values are changed then it will not. Hence, this change is required.

        Attachments

        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            palashk Palash Kala
            Reporter:
            palashk Palash Kala
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: