Uploaded image for project: 'ONOS'
  1. ONOS
  2. ONOS-987

PushHeaderInstructions contains incomplete Ethernet object

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 1.0.1
    • Fix Version/s: 1.1.0, 1.0.2
    • Component/s: None
    • Labels:
      None

      Description

      PushHeaderInstructions uses Ethernet object only to hold ethernet type.

      ethernetType field should be checked as part of this instruction's equality test, but it is not possible, since
      Ethernet object with only ethernet type set is a broken instance, which cannot be compared against another Ethernet instance using `equals()`. (Will result in NPE.)

      // Ethernet class allowing creation of incomplete instance is probably another separate design flaw, which should be addressed at some point.

        Attachments

        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            y-higuchi Yuta Higuchi
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: